Skip to content

Conversation

@metascroy
Copy link
Contributor

Summary:
Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps:

  • In diff 1/3, we backout D81256207, which added more logging
  • In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
  • In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Differential Revision: D82581441

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14526

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job, 1 Pending, 1 Unrelated Failure

As of commit 16d27a4 with merge base 87c44c7 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2025
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 23, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

@mergennachin
Copy link
Contributor

@metascroy did you figure out the root cause of the original revert?

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 24, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 24, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
metascroy added a commit to metascroy/executorch that referenced this pull request Sep 24, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 24, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 24, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 25, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 25, 2025
Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

Summary:


Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:

* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Reviewed By: mergennachin

Differential Revision: D82581441
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581441.

@facebook-github-bot facebook-github-bot merged commit 32b87e0 into pytorch:main Sep 25, 2025
279 of 286 checks passed
@metascroy
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c critical

@metascroy
Copy link
Contributor Author

@metascroy did you figure out the root cause of the original revert?

Still investigating with internal teams. I do not think there was an issue with the OSS builds, though.

pytorchbot pushed a commit that referenced this pull request Sep 25, 2025
Differential Revision: D82581441

Pull Request resolved: #14526

(cherry picked from commit 32b87e0)
@pytorchbot
Copy link
Collaborator

Cherry picking #14526

The cherry pick PR is at #14612 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

GregoryComer pushed a commit that referenced this pull request Sep 29, 2025
Differential Revision: D82581441

Pull Request resolved: #14526

(cherry picked from commit 32b87e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants